This repository was archived by the owner on Dec 16, 2020. It is now read-only.
implement expression context in Wasm#343
Merged
PiotrSikora merged 2 commits intoenvoyproxy:masterfrom Dec 12, 2019
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
This was referenced Dec 9, 2019
jplevyak
reviewed
Dec 10, 2019
|
|
||
| // CEL evaluation | ||
| virtual std::vector<const google::api::expr::runtime::CelFunction*> | ||
| FindFunctionOverloads(absl::string_view) const override { |
Contributor
There was a problem hiding this comment.
Functions start with a lower case letter.
Contributor
Author
There was a problem hiding this comment.
This is an override for a google-style declaration.
jplevyak
approved these changes
Dec 10, 2019
Contributor
Author
|
@bianpengyuan Can you try to update to this and let me know if this fixes istio/proxy#2548 ASAN failure? Note there might be a gap with request.protocol since it may not have been picked up from upstream yet. |
Contributor
|
Sure, will post back. |
Contributor
Author
|
Peter's problem seems to be caused by a different issue (uninitialized struct). |
Contributor
Author
|
@PiotrSikora merge this one, too? |
PiotrSikora
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Implement CEL context in Wasm context.
Harden the getters to handle empty stream info.
Drop request_protocol since it's in upstream now.
Fixes getProperty returning Ok for missing properties.
/assign @jplevyak
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]