Conversation
added 2 commits
March 13, 2020 13:53
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
reviewed
Mar 13, 2020
| done | ||
|
|
||
| # https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/macos/macos-10.14-Readme.md#xcode | ||
| sudo xcode-select --switch /Applications/Xcode_11.3.app |
Contributor
There was a problem hiding this comment.
Actually this will probably break CI
Member
Author
There was a problem hiding this comment.
the 10.15 machines have 11.3.1 and I updated .bazelrc
Contributor
|
Is the submodule update deliberate? |
Member
Author
|
Yep, because we need envoyproxy/envoy#10357 |
rebello95
approved these changes
Mar 13, 2020
junr03
added a commit
that referenced
this pull request
Mar 18, 2020
Description: After #750 I moved the deps install to use the script in Envoy. This means that the CI checkout needs to be recursive. The only path not updated was the cocoapods artifact. This PR fixes it. Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: move mac ci setup to use envoy's script. I don't see much of a point in keeping a separate script here. For instance, envoyproxy/envoy#10357 updated to fix bazel after CI images broke. Instead of keeping up-to-date we can piggy back on efforts in upstream Envoy. Obviously, if diverging needs evolve we might need a second script in Envoy Mobile that calls the Envoy script, and does additional work.
Risk Level: low, CI will let us know if I screwed up.
Testing: CI
Signed-off-by: Jose Nino jnino@lyft.com