Skip to content

stats: emit stats for retries#718

Merged
rebello95 merged 1 commit intomasterfrom
whitelist-stats
Mar 2, 2020
Merged

stats: emit stats for retries#718
rebello95 merged 1 commit intomasterfrom
whitelist-stats

Conversation

@rebello95
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 commented Mar 2, 2020

Adding the following stats to the allow-list based on these Envoy docs:

  • upstream_rq_retry
  • upstream_rq_retry_overflow
  • upstream_rq_retry_success

Also re-alphabetized the stats list.

Signed-off-by: Michael Rebello me@michaelrebello.com

Adding the following stats to the allow-list:

- `upstream_rq_retry`
- `upstream_rq_retry_overflow`
- `upstream_rq_retry_success`

Also re-alphabetized the stats list.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Copy link
Copy Markdown
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rebello95 rebello95 merged commit 8fcd6aa into master Mar 2, 2020
@rebello95 rebello95 deleted the whitelist-stats branch March 2, 2020 23:06
rebello95 added a commit that referenced this pull request Mar 3, 2020
Adding the following stats to the allow-list based on [these Envoy docs](https://www.envoyproxy.io/docs/envoy/latest/configuration/upstream/cluster_manager/cluster_stats):

- `upstream_rq_retry`
- `upstream_rq_retry_overflow`
- `upstream_rq_retry_success`

Also re-alphabetized the stats list.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95 added a commit that referenced this pull request Mar 3, 2020
Adding the following stats to the allow-list based on [these Envoy docs](https://www.envoyproxy.io/docs/envoy/latest/configuration/upstream/cluster_manager/cluster_stats):

- `upstream_rq_retry`
- `upstream_rq_retry_overflow`
- `upstream_rq_retry_success`

Also re-alphabetized the stats list.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants