dns: add ability to set dns failure refresh rate#714
Merged
Conversation
added 2 commits
February 29, 2020 10:54
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Feb 29, 2020
| @@ -5,22 +5,29 @@ public class EnvoyConfiguration { | |||
| public final String statsDomain; | |||
| public final Integer connectTimeoutSeconds; | |||
| public final Integer dnsRefreshSeconds; | |||
Member
Author
There was a problem hiding this comment.
I considered putting all of the dns settings into a struct (same on iOS), but ultimately decided to keep this flat for this change.
I think if this lists keeps growing we need to first think about how we are going to manage config as it gets more unruly. But for now keeping it flat seemed the least intrusive change.
rebello95
previously approved these changes
Mar 2, 2020
Contributor
rebello95
left a comment
There was a problem hiding this comment.
LGTM with minor comments (I can update since you're OOO)
library/java/src/io/envoyproxy/envoymobile/engine/EnvoyConfiguration.java
Outdated
Show resolved
Hide resolved
library/java/test/io/envoyproxy/envoymobile/engine/EnvoyConfigurationTest.kt
Outdated
Show resolved
Hide resolved
library/java/test/io/envoyproxy/envoymobile/engine/EnvoyConfigurationTest.kt
Outdated
Show resolved
Hide resolved
rebello95
approved these changes
Mar 2, 2020
rebello95
pushed a commit
that referenced
this pull request
Mar 3, 2020
Description: updates envoy ref to include envoyproxy/envoy#10137. Exposes client builder function to add dns failure refresh rate. Risk Level: low, new configuration option Testing: local apps, CI Docs Changes: created #715 to create a section in the docs for all the builder options. Fixes #673 Signed-off-by: Michael Rebello <me@michaelrebello.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: updates envoy ref to include envoyproxy/envoy#10137. Exposes client builder function to add dns failure refresh rate.
Risk Level: low, new configuration option
Testing: local apps, CI
Docs Changes: created #715 to create a section in the docs for all the builder options.
Fixes #673