Skip to content

ci: run SwiftLint on CI#62

Merged
rebello95 merged 10 commits intomasterfrom
swiftlint
Jun 10, 2019
Merged

ci: run SwiftLint on CI#62
rebello95 merged 10 commits intomasterfrom
swiftlint

Conversation

@rebello95
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 commented Jun 10, 2019

Resolves #26

Signed-off-by: Michael Rebello mrebello@lyft.com

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

WIP: Still testing/tweaking

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
This reverts commit fbe926b.

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

Example failure:

Screen Shot 2019-06-10 at 2 01 01 PM

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@rebello95 rebello95 requested a review from junr03 June 10, 2019 21:55
Copy link
Copy Markdown
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rebello95 rebello95 merged commit c91f93d into master Jun 10, 2019
@rebello95 rebello95 deleted the swiftlint branch June 10, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swift: enforce style guide via SwiftLint

3 participants