ios: only buffer when requests support retries#521
Merged
Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
b64150f to
063516b
Compare
Signed-off-by: Michael Rebello <me@michaelrebello.com>
junr03
approved these changes
Oct 18, 2019
Member
junr03
left a comment
There was a problem hiding this comment.
Discussed offline having a full fledge platform level struct to parallel envoy_stream_options. Decided that while we only expose one option we can leave the API as an bool argument.
| public func send(_ request: Request, handler: ResponseHandler) -> StreamEmitter { | ||
| let httpStream = self.engine.startStream(with: handler.underlyingCallbacks) | ||
| let httpStream = self.engine.startStream( | ||
| with: handler.underlyingCallbacks, bufferForRetry: request.retryPolicy != nil) |
Member
There was a problem hiding this comment.
nice, the end-user does not have to know about the tie between the stream option and retrying.
junr03
added a commit
that referenced
this pull request
Oct 23, 2019
Description: android parallel to #521. Risk Level: low - matching ios functionality Testing: unit tests Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to utilize the options exposed in #520 to prevent unnecessarily buffering requests that will never be retried. This can be especially useful for preventing buffering of long-lived [gRPC] streams, for example.
We discussed having a full fledged platform level struct to parallel
envoy_stream_options, but decided that while we only expose one option we can leave the API as a boolean argument.Matching Android functionality is being tracked here: #524.
Signed-off-by: Michael Rebello me@michaelrebello.com