Work around BoringSSL bitcode linker warning#470
Merged
Conversation
When linking envoy-mobile to an iOS app that ships with bitcode, you get these warnings from the linker: ``` ld: warning: Linker asked to preserve internal global: 'sk_CRYPTO_BUFFER_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ``` I have submitted an upstream patch to fix this https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the meantime I've applied that patch here. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
rebello95
previously approved these changes
Sep 28, 2019
Contributor
rebello95
left a comment
There was a problem hiding this comment.
Would you mind filing an issue in this repo to track this as well? Thanks!!
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Contributor
|
thanks @keith! |
Member
Author
|
Lets hold on this until we have some clarity upstream about this fix |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
rebello95
approved these changes
Oct 1, 2019
Member
Author
|
Going to update the upstream conversation but this is fine for now |
alyssawilk
added a commit
that referenced
this pull request
Nov 2, 2022
Reverting #470 which is a patch to boringssl https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy#23758 Fixes #471 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linking envoy-mobile to an iOS app that ships with bitcode, you get
these warnings from the linker:
I have submitted an upstream patch to fix this
https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the
meantime I've applied that patch here.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com