security: tls configuration for baseline security#437
Merged
Conversation
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
b8fa00a to
88b2a64
Compare
Signed-off-by: Mike Schore <mike.schore@gmail.com>
rebello95
previously approved these changes
Sep 12, 2019
Contributor
rebello95
left a comment
There was a problem hiding this comment.
Thanks! Would you mind also linking the ticket in your PR description so it closes when this merges?
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
junr03
approved these changes
Sep 13, 2019
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR inlines certificates for trusted certificate authorities into the config template and adds subject alt name verification to the base cluster. The certificate bundle is the same as that presented in MacOS 10.14.6
Risk Level: High
Testing: Simulator
Fixes #322