Conversation
added 4 commits
August 20, 2019 11:31
rebello95
reviewed
Aug 20, 2019
|
|
||
| /// Performs necessary setup after Envoy has initialized and started running. | ||
| /// TODO: create a post-initialization callback from Envoy to handle this automatically. | ||
| - (void)setup; |
| _platformObserver = observer; | ||
|
|
||
| // Create callback context | ||
| ios_context *context = (ios_context *)malloc(sizeof(ios_context)); |
Contributor
There was a problem hiding this comment.
Did these actually cause problems?
Member
Author
There was a problem hiding this comment.
nope, the cast is just not needed. I'll open another PR to homogenize this style.
library/swift/src/Envoy.swift
Outdated
| extension Envoy: Client { | ||
| public func startStream(with request: Request, handler: ResponseHandler) -> StreamEmitter { | ||
| let httpStream = self.engine.startStream(with: handler.underlyingObserver) | ||
| NSLog("Sending request with headers: \(request.outboundHeaders())") |
Member
Author
There was a problem hiding this comment.
sure. I thought this was a pretty good log line to have. Is there a way to define log levels with NSLog?
Member
Author
There was a problem hiding this comment.
For the future. I will remove this for now.
Contributor
There was a problem hiding this comment.
Nope, unfortunately no log levels with NSLog. I think this would be good to have in the demos but maybe not the engine for now
rebello95
previously approved these changes
Aug 20, 2019
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
approved these changes
Aug 20, 2019
rebello95
added a commit
that referenced
this pull request
Aug 20, 2019
**This is a working end-to-end iOS implementation using Envoy Mobile as a library!** Depends on #312 and #353. Updates our Swift example app to use the Envoy Mobile direct interfaces rather than using `URLSession` and Envoy as a listener. Note: For now, we are no longer showing the text response of the response body due to the fact that the underlying implementation is not yet complete for bodied requests (headers-only). Signed-off-by: Michael Rebello <me@michaelrebello.com> 
rebello95
added a commit
that referenced
this pull request
Aug 20, 2019
#353 broke the `format_all` test on CI on master. This fixes it by running the formatter and pushing the diff. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
that referenced
this pull request
Aug 20, 2019
#353 broke the `format_all` test on CI on master. This fixes it by running the formatter and pushing the diff. Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
**This is a working end-to-end iOS implementation using Envoy Mobile as a library!** Depends on envoyproxy/envoy-mobile#312 and envoyproxy/envoy-mobile#353. Updates our Swift example app to use the Envoy Mobile direct interfaces rather than using `URLSession` and Envoy as a listener. Note: For now, we are no longer showing the text response of the response body due to the fact that the underlying implementation is not yet complete for bodied requests (headers-only). Signed-off-by: Michael Rebello <me@michaelrebello.com>  Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
envoyproxy/envoy-mobile#353 broke the `format_all` test on CI on master. This fixes it by running the formatter and pushing the diff. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
**This is a working end-to-end iOS implementation using Envoy Mobile as a library!** Depends on envoyproxy/envoy-mobile#312 and envoyproxy/envoy-mobile#353. Updates our Swift example app to use the Envoy Mobile direct interfaces rather than using `URLSession` and Envoy as a listener. Note: For now, we are no longer showing the text response of the response body due to the fact that the underlying implementation is not yet complete for bodied requests (headers-only). Signed-off-by: Michael Rebello <me@michaelrebello.com>  Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
envoyproxy/envoy-mobile#353 broke the `format_all` test on CI on master. This fixes it by running the formatter and pushing the diff. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: this PR fixes a couple bugs to allow e2e use of the Envoy Mobile library in the swift iOS demo.
Risk Level: low - fixing bugs
Testing:
./bazelw build --config=ios --xcode_version=10.3.0.10G8 //:ios_distand then./bazelw run --config=ios --xcode_version=10.3.0.10G8 //examples/swift/hello_world:appSigned-off-by: Jose Nino jnino@lyft.com