swift: expose URL components instead of URL type#277
Merged
Conversation
As we bridge over the platform layers to talk to the C/C++ core, we'll need to be able to send headers such as `:method`/`:scheme`/`:authority`. The `URL` type exposes optionals for these properties, which means we need to either handle them at initialization time or at the time when the request is executed by unwrapping them and throwing/failing. In order to prevent throwing when deconstructing `URL` components, we are instead updating the interfaces to accept these 3 fields separately. Signed-off-by: Michael Rebello <mrebello@lyft.com>
buildbreaker
approved these changes
Jul 22, 2019
buildbreaker
left a comment
There was a problem hiding this comment.
Looks good. I'll make the same change for Kotlin shortly
buildbreaker
pushed a commit
that referenced
this pull request
Jul 23, 2019
To mirror: #277 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: expose URL components instead of URL type Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:]
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
To mirror: envoyproxy/envoy-mobile#277 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: expose URL components instead of URL type Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
To mirror: envoyproxy/envoy-mobile#277 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: expose URL components instead of URL type Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we bridge over the platform layers to talk to the C/C++ core, we'll need to be able to send headers such as
:method/:scheme/:authority.The
URLtype exposes optionals for these properties, which means we need to either handle them at initialization time or at the time when the request is executed by unwrapping them and throwing/failing.In order to prevent throwing when deconstructing
URLcomponents, we are instead updating the interfaces to accept these 3 fields separately.Signed-off-by: Michael Rebello mrebello@lyft.com