swift: throw when setting restricted headers#275
Closed
Conversation
Since we expose headers in the `Request` type, it's technically possible for consumers to set restricted headers that we will be setting internally within the library (any header starting with `:` in this case - `:method` for example). To prevent this, we will throw an error when any of these headers/trailers is set manually. Context: https://envoyproxy.slack.com/archives/CKQ2LK23G/p1563826656004700 Signed-off-by: Michael Rebello <mrebello@lyft.com>
Contributor
Author
|
Will likely close this PR instead of merging in order to prevent the poor ergonomics of having to |
Contributor
Author
|
Superseded by #288 |
rebello95
added a commit
that referenced
this pull request
Jul 23, 2019
Adds converters to go from `Request` to a set of headers that upstream Envoy understands. This will be utilized by the request logic in the `Envoy` class. Previous consideration: #275 Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Adds converters to go from `Request` to a set of headers that upstream Envoy understands. This will be utilized by the request logic in the `Envoy` class. Previous consideration: envoyproxy/envoy-mobile#275 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Adds converters to go from `Request` to a set of headers that upstream Envoy understands. This will be utilized by the request logic in the `Envoy` class. Previous consideration: envoyproxy/envoy-mobile#275 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we expose headers in the
Requesttype, it's technically possible for consumers to set restricted headers that we will be setting internally within the library (any header starting with:in this case -:methodfor example).To prevent this, we will throw an error when any of these headers/trailers is set manually.
Context: https://envoyproxy.slack.com/archives/CKQ2LK23G/p1563826656004700
Signed-off-by: Michael Rebello mrebello@lyft.com