android proxy: add support for PAC proxies#2591
Merged
Augustyniak merged 6 commits intomainfrom Oct 4, 2022
Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
previously approved these changes
Oct 4, 2022
Contributor
jpsim
left a comment
There was a problem hiding this comment.
Could you file a ticket to track wiring this up on the C++ builder?
library/java/io/envoyproxy/envoymobile/engine/AndroidProxyMonitor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
There is an existing issue for that #2547 already. |
jpsim
previously approved these changes
Oct 4, 2022
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
previously approved these changes
Oct 4, 2022
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
approved these changes
Oct 4, 2022
colibie
pushed a commit
to colibie/envoy-mobile
that referenced
this pull request
Oct 22, 2022
Description: Add support for PAC proxies. Fixes envoyproxy#2531. Risk Level: Low, the change should be additive and it's guarded with an engine builder flag (`enableProxying(true/false)` that's disabled by default. Testing: Manual testing for PAC proxies, integrations tests for other types of proxies. Docs Changes: N/A Release Notes: WIP Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: Chidera Olibie <colibie@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add support for PAC proxies. Fixes #2531.
Risk Level: Low, the change should be additive and it's guarded with an engine builder flag (
enableProxying(true/false)that's disabled by default.Testing: Manual testing for PAC proxies, integrations tests for other types of proxies.
Docs Changes: N/A
Release Notes: WIP
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com