Skip to content

Revert "android: use local addresses as opposed to prefix"#2307

Merged
jpsim merged 1 commit intomainfrom
revert-2081-fz/android-ifaddrs
May 20, 2022
Merged

Revert "android: use local addresses as opposed to prefix"#2307
jpsim merged 1 commit intomainfrom
revert-2081-fz/android-ifaddrs

Conversation

@jpsim
Copy link
Copy Markdown
Contributor

@jpsim jpsim commented May 20, 2022

Reverts #2081

This broke detection of ipv6 interfaces.

This reverts commit 1b34577.

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim force-pushed the revert-2081-fz/android-ifaddrs branch from 10c76e5 to ed0dc62 Compare May 20, 2022 18:25
@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented May 20, 2022

No changelog entry for this since the bug was only ever shipped in pre-release versions.

@jpsim jpsim requested review from Augustyniak and goaway May 20, 2022 18:35
@jpsim jpsim merged commit 3b16749 into main May 20, 2022
@jpsim jpsim deleted the revert-2081-fz/android-ifaddrs branch May 20, 2022 23:05
jpsim added a commit that referenced this pull request May 26, 2022
* origin/main: (32 commits)
  Compress xcframework release asset (#2324)
  bazel: update rules_apple (#2326)
  Merge `android_dist` with `android_dist_ci` (#2323)
  kotlin: fix flaky receive error test (#2317)
  kotlin: fix flaky grpc test (#2316)
  build(deps): bump pyjwt from 2.1.0 to 2.4.0 in /.github/actions/pr_notifier (#2314)
  test: making C++ integration test more authentic (#2315)
  reverting override to override_request_timeout_by_gateway_timeout (#2296)
  Update Envoy (#2309)
  release: use `CREDENTIALS_GITHUB_RELEASE_DEPLOY_KEY`
  Use `CREDENTIALS_GITHUB_PUSH_TOKEN`
  Push to branch before tagging the release
  Cronvoy: preparation to unittest certificate verification JNI (#2251)
  Corrected typo in documentation for Android building requirements (#2313)
  instrumentation: add timers and warnings to platform callbacks (#2300)
  Bump Lyft Support Rotation (#2310)
  Revert "android: use local addresses as opposed to prefix (#2081)" (#2307)
  Fix release GitHub workflow (#2306)
  mobile: moving the c++ integration test to use default config (#2293)
  config: cleaning up deprecated configs (#2295)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants