cleanup: remove the unused stats sink metrics_service#2220
Merged
jpsim merged 1 commit intoenvoyproxy:mainfrom Apr 27, 2022
Merged
cleanup: remove the unused stats sink metrics_service#2220jpsim merged 1 commit intoenvoyproxy:mainfrom
jpsim merged 1 commit intoenvoyproxy:mainfrom
Conversation
This was discovered because running tools/vscode_compdb.sh was failing due to build failures in metrics_service. snowp@ mentioned in the removed. Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
|
/assign-from @envoyproxy/maintainers |
Contributor
|
thanks for the clean up! |
Contributor
|
Thanks for the PR! This does indeed appear unused. |
jpsim
approved these changes
Apr 27, 2022
jpsim
added a commit
that referenced
this pull request
May 3, 2022
…rtion * origin/main: (57 commits) network: add enableDrainPostDnsRefresh to iOS (#2242) envoy: update to em-cherry (#2241) network: support draining connections after triggered DNS refresh (#2225) Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Cleanup: remove the unused stats sink metrics_service (#2220) bazel: move back to symbol mapping table files (#2218) Add new version history section (#2209) build: simplify jnilib copy (#2214) ci: Update macOS version to macOS 12 (#2208) Update releasing.rst (#2200) support: Post Lyft support rotation changes to Slack (#2207) Don't run bump_support_rotation GitHub Action on forks (#2204) Release 0.4.6 (#2201) ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered because running tools/vscode_compdb.sh was failing
due to build failures in metrics_service. A discussion on the
envoy-mobile slack channel
mentioned that the metrics_service sink is no longer used and can be
removed.
Risk Level: Low
Testing: Relying on CI
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Ali Beyad abeyad@google.com