internal: pass engine handles throughout API#2149
Merged
Conversation
In preparation for removing the singleton. This is split off into its own independent change to minimize the scope of the main singleton removal work. We were already doing this in many places, this just adds more instances of passing the engine handle so we do so comprehensively. Signed-off-by: JP Simard <jp@jpsim.com>
79fbb8e to
b562382
Compare
Signed-off-by: JP Simard <jp@jpsim.com>
goaway
reviewed
Apr 11, 2022
| private static volatile AndroidNetworkMonitor instance = null; | ||
|
|
||
| private int previousNetworkType = ConnectivityManager.TYPE_DUMMY; | ||
| private long engineHandle; |
Contributor
There was a problem hiding this comment.
How about we store a reference to the engine, and let the engine make the JNI call, so we don't have to expose the handle?
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Apr 12, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Apr 12, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Apr 13, 2022
* main: internal: pass engine handles throughout API (#2149) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Apr 14, 2022
…rash * origin/main: bazel: Allow multiple definitions for armeabi android links internal: pass engine handles throughout API (#2149) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Apr 20, 2022
…unroutable-families * origin/main: (25 commits) Update Envoy to c96f711 (envoyproxy#2168) Bump Lyft Support Rotation (envoyproxy#2162) Update Envoy to 0e8899c (envoyproxy#2166) Update rules_apple & rules_swift (envoyproxy#2167) bazel: set inmemory remote exec flags globally http client: add cancel log and limit callback to open streams (envoyproxy#2165) bump envoy to 5181d2355f208061688922572727fe06ba8b3a07 (envoyproxy#2157) pin maven dependencies (envoyproxy#2161) Fix iOS termination crash in `ProvisionalDispatcher` (envoyproxy#2059) bazel: Allow multiple definitions for armeabi android links internal: pass engine handles throughout API (envoyproxy#2149) Bump Lyft Support Rotation (envoyproxy#2156) add specifying more maven deps (envoyproxy#2151) update envoy@e4eaf1b97 (envoyproxy#2146) bazel: create symbol mapping file (envoyproxy#2126) Bump Lyft Support Rotation (envoyproxy#2148) bazel: remove sandbox disable build: export flatbuffer jvm dep (envoyproxy#2147) Bump Lyft Support Rotation (envoyproxy#2143) bazel: Add flatbuffers Swift hack ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for removing the singleton. This is split off into its own independent change to minimize the scope of the main singleton removal work.
We were already doing this in many places, this just adds more instances of passing the engine handle so we do so comprehensively.
Description: Pass engine handles throughout API
Risk Level: Medium, changing some JNI interfaces, removing some static state
Testing: Unit tests and sample apps
Docs Changes: N/A internal only
Release Notes: N/A internal only
[Optional Fixes #Issue]
[Optional Deprecated:]
Signed-off-by: JP Simard jp@jpsim.com