Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
mattklein123
approved these changes
Mar 8, 2022
Comment on lines
+234
to
+239
| retry_policy: | ||
| per_try_idle_timeout: *per_try_idle_timeout | ||
| retry_back_off: | ||
| base_interval: 0.25s | ||
| max_interval: 60s | ||
| - name: primary |
Member
There was a problem hiding this comment.
I would share this retry policy if possible
Contributor
There was a problem hiding this comment.
Good callout - the next PR (based on this) moves more routing decisions into actual config, so I'll include it there.
Augustyniak
approved these changes
Mar 8, 2022
Contributor
|
Thanks @Augustyniak and @mattklein123! |
Contributor
|
This PR broke the async_await iOS example app
I'm investigating now. It was also failing on CI in this PR, so I'm curious why we merged this despite the failure. Did anyone investigate already? |
jpsim
added a commit
that referenced
this pull request
Mar 10, 2022
It was never safe to do a case-sensitive lookup, but this broke in #2088 (comment). Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Mar 10, 2022
It was never safe to do a case-sensitive lookup, but this broke in #2088 (comment). Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Mar 14, 2022
* origin/main: [CI] Only install Android tool dependencies when needed (#2095) update envoy to latest (#2094) [CI] Fix DCO in support rotation bump PRs (#2092) Fix iOS async/await example app (#2093) Test for Brotli decompressor (#2066) docs: fix day (#2089) engine builder: add option to add a list of H2-Raw domain names (#2088) docs: adding the community meeting (#2083) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
It was never safe to do a case-sensitive lookup, but this broke in envoyproxy/envoy-mobile#2088 (comment). Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds public API and support for providing a list of domains to which H2 connections will be established without protocol negotiation (i.e. ALPN). See Envoy docs for the domain name patterns supported:
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-route
Risk Level: Low
Testing: Unit
Co-authored-by: Mike Schore mike.schore@gmail.com
Signed-off-by: Mike Schore mike.schore@gmail.com