Skip to content

CI: Re-enable engflow for kotlin tests#2071

Merged
jpsim merged 14 commits intoenvoyproxy:mainfrom
lfpino:luis-jdk-fix4
Mar 1, 2022
Merged

CI: Re-enable engflow for kotlin tests#2071
jpsim merged 14 commits intoenvoyproxy:mainfrom
lfpino:luis-jdk-fix4

Conversation

@lfpino
Copy link
Copy Markdown
Contributor

@lfpino lfpino commented Feb 22, 2022 •
edited
Loading

Signed-off-by: Luis Fernando Pino Duque luis@engflow.com

Description:
Re-enable engflow for kotlin tests by using JDK 8 and allowing pulse_client_impl_test and engine_builder_test to run without a sandbox. Those tests are trying to access a path under "/var/folders/wp/..." as part of one of the mock initializations, however, the sandbox doesn't allow that. The real fix will come next where we add those paths to the allow-list

Risk Level: Low
Testing: See android_tests workflow
Docs Changes: N/A
Release Notes: N/A
Fixes #2020

lfpino added 13 commits February 22, 2022 16:15
@lfpino
Re-enable engflow for kotlin tests
a915bb3 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Local java8
b8810bf 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Remove android_build
6f054c2 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Kick CI
a45a186 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Kick CI
945a007 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Test without sandbox
ce19564 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Kick CI
7bc83fd 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Add JVM flag
00acf69 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Remove sandbox
7030b4e 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Remove flags
432744d 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Restore other flows and refactor flags
6cb9deb 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Revert android_tests
20b3b73 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Add missing flag
fdfe7d0 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino lfpino marked this pull request as ready for review February 24, 2022 10:52
@lfpino
Copy link
Copy Markdown
Contributor Author

lfpino commented Feb 24, 2022

@jpsim could you please take a look?

@lfpino lfpino mentioned this pull request Feb 25, 2022
Closed
jpsim
jpsim approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real fix will come next where we add those paths to the allow-list

Sounds right, looking forward to it.

These changes look good to me in the short term.

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 28, 2022

@lfpino looks like the java_tests_mac job is repeatedly failing with the following errors:

/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 260: fg: no job control
/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 261: fg: no job control
/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 262: fg: no job control
JUnit4 Test Runner
.....
Time: 0.139

OK (5 tests)


BazelTestRunner exiting with a return value of 0
JVM shutdown hooks (if any) will run now.
The JVM will exit once they complete.

-- JVM shutdown starting at 2022-02-28 16:26:10 --

@lfpino
Kick CI
643332c 
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Copy link
Copy Markdown
Contributor Author

lfpino commented Mar 1, 2022

@jpsim I think that was a flake, could you please merge? If you see the flake again please open an issue and I'll investigate

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Mar 1, 2022

If you see the flake again please open an issue and I'll investigate

will do

@jpsim jpsim merged commit 66ce0b5 into envoyproxy:main Mar 1, 2022
goaway added a commit that referenced this pull request Mar 1, 2022
@goaway
Revert "CI: Re-enable engflow for kotlin tests (#2071)"
83a0320 
This reverts commit 66ce0b5.

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpsim jpsim jpsim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Run integration tests on EngFlow

2 participants

@lfpino @jpsim