Default timestamp to -1 for envoy_final_stream_intel#2006
Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom Jan 20, 2022
Merged
Default timestamp to -1 for envoy_final_stream_intel#2006alyssawilk merged 4 commits intoenvoyproxy:mainfrom
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
alyssawilk
suggested changes
Jan 18, 2022
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
jpsim
reviewed
Jan 18, 2022
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
alyssawilk
approved these changes
Jan 18, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
I think this is fine but definitely needs Lyft sign-off
goaway
approved these changes
Jan 20, 2022
Contributor
goaway
left a comment
There was a problem hiding this comment.
I'm okay proceeding with this as it follows the existing convention. That said, I would generally prefer if we used real optionals for public fields that might not be present, both because it aligns better with the Swift and Kotlin ecosystems, and because it's a better representation for "lack of a value" in general.
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* origin/main: (21 commits) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Run Kotlin macOS tests without EngFlow (envoyproxy#2018) final_intel: adding response flags (envoyproxy#2009) fix (envoyproxy#2025) stream intel: update kotlin public interface to align with swift (envoyproxy#2013) tls: update bundled root certificates (envoyproxy#2016) tooling: first pass at oncall tooling (envoyproxy#2014) test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test (envoyproxy#2007) envoy: 519774f742 (envoyproxy#2015) Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006) QuicTestServer (envoyproxy#1989) bump boringssl to Envoy's version (envoyproxy#1999) docs: addding release notes (envoyproxy#2001) release: cutting the 0.4.5 release (envoyproxy#2000) Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998) Decompress even when `no-transform` is specified (envoyproxy#1995) ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Default timestamp to -1 for envoy_final_stream_intel
Risk Level: small
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Charles Le Borgne cleborgne@google.com