Closed
Conversation
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
…TestServer Signed-off-by: Chidera Olibie <colibie@google.com>
…TestServer Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
…TestServer Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
colibie
commented
Oct 11, 2021
Contributor
Author
colibie
left a comment
There was a problem hiding this comment.
@carloseltuerto @goaway @alyssawilk could you please review the code, while I figure out the CI failures. Thanks.
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
alyssawilk
reviewed
Oct 12, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
so exciting to see this land!
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
alyssawilk
reviewed
Oct 13, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
C++ LGTM (modulo the CI issues). Hurrah!
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
carloseltuerto
previously approved these changes
Oct 15, 2021
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Merged
Contributor
|
Are we still trying to land this? |
Contributor
|
This was submitted with another PR: #2058 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a quic test server and a simple test verifying the test server. This test server is a java version based on Envoy's autonomousUpstream. If configured correctly, this server can function as a h1/h2/h3 server. This is an MVP.
Risk Level: N/A
Testing: Contains a test.
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]