Have QuicTestServer to support Cronet request#2058
Merged
carloseltuerto merged 6 commits intoenvoyproxy:mainfrom Feb 16, 2022
Merged
Have QuicTestServer to support Cronet request#2058carloseltuerto merged 6 commits intoenvoyproxy:mainfrom
carloseltuerto merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
Signed-off-by: Charles Le Borgne <cleborgne@google.com>
alyssawilk
reviewed
Feb 15, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
do we want to turn up one of the cronet tests to make sure this works e2e?
Contributor
Author
|
I wish. But then I would need to configure Cronvoy in such a way that it would be able to establish an H3 connection to an H3 test server. |
alyssawilk
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to mimic this: https://source.chromium.org/chromium/chromium/src/+/main:components/cronet/testing/test_server/data/quic_data/simple.txt
The original QuicTestServer reads that file and caches it while booting up, and precomputes the full response out of it.
Description: provide a canned response to a specific request.
Risk Level: N/A - only changes test infrastructure
Testing: CI
Docs Changes: N/A
Release Notes: N/A