Skip to content

test: fix RawConnectionDriver#122

Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
lambdai:rcd
May 4, 2020
Merged

test: fix RawConnectionDriver#122
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
lambdai:rcd

Conversation

@lambdai
Copy link
Copy Markdown
Contributor

@lambdai lambdai commented May 3, 2020 •
edited
Loading

To go with envoyproxy/envoy#10998

We will introduce a small downtime when building from envoy-filter-example:master before envoyproxy/envoy#10998 is merged.

Signed-off-by: Yuchen Dai silentdai@gmail.com

@lambdai
test: fix RawConnectionDriver
c320570 
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai
Copy link
Copy Markdown
Contributor Author

lambdai commented May 3, 2020

After set the envoy repo to local directory which reflects envoyproxy/envoy#10998
$ bazel test //:echo2_integration_test //http-filter-example:http_filter_integration_test //:envoy_binary_test
//:envoy_binary_test (cached) PASSED in 2.1s
//:echo2_integration_test PASSED in 2.1s
//http-filter-example:http_filter_integration_test PASSED in 32.9s

@lambdai lambdai mentioned this pull request May 3, 2020
Merged
@lambdai
Copy link
Copy Markdown
Contributor Author

lambdai commented May 3, 2020 •
edited
Loading

It's not wise to push to master because envoyproxy/envoy#10998 is not merged yet.

Could any one create a branch for me to push? I don't have the access rights.
Envoyproxy needs a SHA in this repo. It doesn't have to be master branch.

@lambdai
poor access rights solution
e335207 
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
mattklein123 requested changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

echo2_integration_test.cc Outdated
namespace Envoy {
namespace {

// NoCreateConnectionDriver is used to provide "value" member regardless `createConnectionDriver`
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too complicated. Please just remove all of this and put in the final code that you need. We can force merge it here, and then you can update the SHA of filter example in your other PR. Thank you!

Copy link
Copy Markdown
Contributor Author

@lambdai lambdai May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. It's a great c++ template practice in the weekend though.

I am reverting this PR

@mattklein123 mattklein123 self-assigned this May 4, 2020
@lambdai
Revert "poor access rights solution"
51d14a8 
This reverts commit e335207.

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai
Copy link
Copy Markdown
Contributor Author

lambdai commented May 4, 2020

@mattklein123 reverted and the description of this PR is updated.

mattklein123
mattklein123 approved these changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit b6dccb7 into envoyproxy:master May 4, 2020
@lambdai lambdai deleted the rcd branch May 4, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lambdai @mattklein123