test: extend raw connection driver#10998
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom May 5, 2020
Merged
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
requested changes
Apr 29, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Yes at a high level this is perfect, thanks. Let's get the other change in first since you are close on that one and then we can circle back on this one?
/wait
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Member
|
Nice! Can you check CI? /wait |
Contributor
Author
|
It's a build failure at https://github.com/envoyproxy/envoy-filter-example because the RawConnectionDriver ctor update. It's a chicken-egg problem. One of the solution is to migrate in 3 steps
Any alternative? @mattklein123 |
Member
|
You can make the update in filter-example and we can force merge it, and then you can include that SHA update in this PR (we pin to a SHA of filter example in do_ci.sh) |
Contributor
Author
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Avoid dispatcher allocation. Allow passing ssl transport socket. Add waitForConnected helper method.
Additional Description:
Inspired and will be used by #10662
Risk Level: LOW
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]