Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
htuch
reviewed
Dec 30, 2019
echo2_config.cc
Outdated
| } | ||
|
|
||
| std::string name() override { return "echo2"; } | ||
| const std::string name() const override { return "echo2"; } |
Member
There was a problem hiding this comment.
Why is this const std::string()? It should either be std::string or const std::string& I think.
Contributor
Author
There was a problem hiding this comment.
I didn't want the filter to own its name string. Fine dropping const from std::string if you think that's better.
Member
There was a problem hiding this comment.
Well, const std::string for a return value doesn't do anything so it should be dropped IMHO.
Signed-off-by: Kuat Yessenov <kuat@google.com>
Member
|
@kyessenov, sorry, does that https://circleci.com/gh/envoyproxy/envoy-filter-example/6958 |
Contributor
Author
|
Argh, sorry. It's coupled with my PR
envoyproxy/envoy#9391, not sure how to pull off
making both repos pass.
…On Mon, Dec 30, 2019 at 5:10 PM Dhi Aurrahman ***@***.***> wrote:
@kyessenov <https://github.com/kyessenov>, sorry, does that name() should
override
https://github.com/envoyproxy/envoy/blob/11934bd081011cd7d58a9d49be4965917cce8aa0/include/envoy/server/filter_config.h#L349?
Seems like it's failing?
https://circleci.com/gh/envoyproxy/envoy-filter-example/6958
echo2_config.cc:28:28: error: non-virtual member function marked 'override' hides virtual member function
std::string name() const override { return "echo2"; }
^
bazel-out/k8-fastbuild/bin/external/envoy/include/envoy/server/_virtual_includes/filter_config_interface/envoy/server/filter_config.h:349:23: note: hidden overloaded virtual function 'Envoy::Server::Configuration::NamedNetworkFilterConfigFactory::name' declared here: different qualifiers (unqualified vs 'const')
virtual std::string name() PURE;
^
In file included from echo2_config.cc:5:
bazel-out/k8-fastbuild/bin/external/envoy/include/envoy/registry/_virtual_includes/registry/envoy/registry/registry.h:322:5: error: field type 'Envoy::Server::Configuration::Echo2ConfigFactory' is an abstract class
T instance_{};
^
echo2_config.cc:36:87: note: in instantiation of template class 'Envoy::Registry::RegisterFactory<Envoy::Server::Configuration::Echo2ConfigFactory, Envoy::Server::Configuration::NamedNetworkFilterConfigFactory>' requested here
static Registry::RegisterFactory<Echo2ConfigFactory, NamedNetworkFilterConfigFactory> registered_;
^
bazel-out/k8-fastbuild/bin/external/envoy/include/envoy/server/_virtual_includes/filter_config_interface/envoy/server/filter_config.h:349:23: note: unimplemented pure virtual method 'name' in 'Echo2ConfigFactory'
virtual std::string name() PURE;
^
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=ACIYRRQSBGAVH7GAL4PKMN3Q3KL2FA5CNFSM4J7N6DX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3RSIQ#issuecomment-569841954>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIYRRVX655YDK3D6MWN5KDQ3KL2FANCNFSM4J7N6DXQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com