Skip to content

Windows image: add links for expected python executable names#51

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
greenhouse-org:windows-python-symlinks
May 11, 2020
Merged

Windows image: add links for expected python executable names#51
htuch merged 2 commits intoenvoyproxy:masterfrom
greenhouse-org:windows-python-symlinks

Conversation

@sunjayBhatia
Copy link
Copy Markdown
Member

Attempts to fix build issues in: envoyproxy/envoy#11108

- python3, python 3.8
- Attempts to fix build issues in: envoyproxy/envoy#11108

Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia
Copy link
Copy Markdown
Member Author

cc @wrowe

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

…inks

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@htuch htuch merged commit 596a50d into envoyproxy:master May 11, 2020
htuch pushed a commit that referenced this pull request May 11, 2020
  [skip ci]
  Windows image: add links for expected python executable names (#51)

Attempts to fix build issues in: envoyproxy/envoy#11108

Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia sunjayBhatia deleted the windows-python-symlinks branch May 12, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants