shellcheck: Update to v0.7.0#103
Conversation
84d9e45 to
6cd82a5
Compare
|
After this lands it builds an image, and then the image is included by SHA in other places so you can fix things at the same time. Can you check the windows error? |
I was able to download the vs build tools package as expected (https://download.visualstudio.microsoft.com/download/pr/e3850c73-59c6-4c05-9db6-a47a74b67daf/dcb113a854b2cb2141755b6a35c4b9aac6f109081bee45649ec2fcc594b0d7a6/vs_BuildTools.exe) might just need to re-kick the build |
|
@sunjayBhatia thanks, ill kick it now |
|
@phlax in case you need it, see https://github.com/envoyproxy/envoy/pull/12776/files for an example of where all to update the build image tag and the build-tools repo reference |
|
i meant this bd0e1db - but i see now that happens automatically ill create a PR on envoy for new hashes... |
|
Can you merge main? |
|
eek - one mo... |
|
@mattklein123 - im just realizing that we need to land the shellcheck cleanups (envoyproxy/envoy#13362) at same time might be better to land the other pr that updates the hashes first (on envoy) |
|
(Windows failure looks like a flake again) |
Signed-off-by: Ryan Northey <ryan@synca.io>
|
@sunjayBhatia the flake seems to be with downloading: http://repo.msys2.org/distrib/x86_64/msys2-base-x86_64-20200720.tar.xz can we put some kind of retry on the download routine ? |
Trying to download that artifact manually and even visit some pages on the msys2 site is failing, that one might not be retryable |
|
is there a repo.mysys3.org ?
|
[skip ci] shellcheck: Update to v0.7.0 (#103) Signed-off-by: Ryan Northey <ryan@synca.io>
fixes envoyproxy/envoy#13228
im noticing that the last PR i created - some rebuilding needs to happen to images - not sure what - but i can update if someone lmk
also, when this lands it will break (current) master i think, as there are some lint fails that are not currently being caught - im happy to fix these as/before this lands