Allow set sts as call credential for opencensus tracer stub#9877
Merged
mattklein123 merged 15 commits intoenvoyproxy:masterfrom Feb 6, 2020
Merged
Allow set sts as call credential for opencensus tracer stub#9877mattklein123 merged 15 commits intoenvoyproxy:masterfrom
mattklein123 merged 15 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Contributor
|
Does this change need unit tests? |
kyessenov
reviewed
Jan 30, 2020
kyessenov
reviewed
Jan 30, 2020
kyessenov
reviewed
Jan 30, 2020
Contributor
|
The coverage build failure is a tough nut to crack. I had most success with clang-asan coverage build and then fixing ODR violations between tests. |
lizan
reviewed
Jan 31, 2020
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Contributor
Author
|
The test will crash on non-Google instance. |
lizan
approved these changes
Feb 6, 2020
lizan
suggested changes
Feb 6, 2020
Member
lizan
left a comment
There was a problem hiding this comment.
Can you add a line of version history? Thanks!
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
…credential Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Contributor
Author
|
@lizan Done. |
lizan
reviewed
Feb 6, 2020
lizan
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pengyuan Bian bianpengyuan@google.com
cc @mandarjog @kyessenov @JimmyCYJ
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]