test flake: fix flake in ApiListener integration test#9808
Merged
lizan merged 3 commits intoenvoyproxy:masterfrom Jan 24, 2020
junr03:test-flake
Merged
test flake: fix flake in ApiListener integration test#9808lizan merged 3 commits intoenvoyproxy:masterfrom junr03:test-flake
lizan merged 3 commits intoenvoyproxy:masterfrom
junr03:test-flake
Conversation
added 2 commits
January 22, 2020 14:03
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
lizan
approved these changes
Jan 24, 2020
antoniovicente
pushed a commit
to antoniovicente/envoy
that referenced
this pull request
Sep 29, 2020
Description: previously the test was not waiting for the expectation on the server's thread to complete. Therefore, there was a use after free race condition with the ApiListener's TlsCachingDateProvider. This PR makes it so that the test waits for the expectation to be fulfilled and thus prevents the race. Risk Level: low Testing: ran integration test a few thousand times locally on a linux machine. Fixes envoyproxy#9746 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Antonio Vicente <avd@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Sep 29, 2020
…est (#9808) (#13316) Description: previously the test was not waiting for the expectation on the server's thread to complete. Therefore, there was a use after free race condition with the ApiListener's TlsCachingDateProvider. This PR makes it so that the test waits for the expectation to be fulfilled and thus prevents the race. Risk Level: low Testing: ran integration test a few thousand times locally on a linux machine. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Antonio Vicente <avd@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: previously the test was not waiting for the expectation on the server's thread to complete. Therefore, there was a use after free race condition with the ApiListener's TlsCachingDateProvider. This PR makes it so that the test waits for the expectation to be fulfilled and thus prevents the race.
Risk Level: low
Testing: ran integration test a few thousand times locally on a linux machine.
Fixes #9746