Fix scripts for docker build on mac#958
Merged
mattklein123 merged 4 commits intomasterfrom May 15, 2017
Merged
Conversation
Contributor
Author
|
@lyft/network-team |
Member
mattklein123
left a comment
There was a problem hiding this comment.
awesome, thanks. small comments.
ci/README.md
Outdated
|
|
||
| ```bash | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev.server_only' | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.debug.server_only' |
Member
There was a problem hiding this comment.
This doesn't actually match the output directory above AFAIK. I would just switch back to dev and remove server_only
docs/install/sandboxes.rst
Outdated
| That command will take some time to run because it is compiling an envoy binary. | ||
|
|
||
| For more information on building, please refer to | ||
| `this documentation <https://github.com/lyft/envoy/tree/master/ci#building-and-running-tests-as-a-developer>`_. |
Member
There was a problem hiding this comment.
nit: you can use :repo: here (search other docs)
htuch
reviewed
May 14, 2017
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo comments, thanks for fixing this.
ci/README.md
Outdated
|
|
||
| ```bash | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev.server_only' | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.debug.server_only' |
htuch
reviewed
May 15, 2017
|
|
||
| ```bash | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev.server_only' | ||
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev' |
Member
There was a problem hiding this comment.
This runs all the tests as well, is this intentional?
Contributor
Author
There was a problem hiding this comment.
It is intentional as to match where the binary can be found.
htuch
reviewed
May 15, 2017
| $ pwd | ||
| src/envoy | ||
| $ docker run -t -i -v <SOURCE_DIR>:/source lyft/envoy-build:latest /bin/bash -c "cd /source && ci/do_ci.sh normal" | ||
| $ ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev' |
Contributor
Author
There was a problem hiding this comment.
It is intentional here.
Contributor
Author
There was a problem hiding this comment.
I will update the comment below to mention that it runs tests as well. And make the link to the readme to find other do_ci targets.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Refactory auth filter **What this PR does / why we need it**: To have per-thread public key cache. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This refactors basic.yaml which has been exploding in its size. Since we can have multiple AIGatewayRoutes attached to a gateway, we can split them into each provider file, which aligns with the documentation pages (connect-provider/*) as well. **Related Issues/PRs (if applicable)** Closes #956 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac users require running the docker command with root permission.