all: upgrade Envoy source to v3alpha API.#9546
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jan 6, 2020
Merged
all: upgrade Envoy source to v3alpha API.#9546mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
9738709 to
3a66c1f
Compare
lizan
reviewed
Jan 3, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@envoyproxy/api-shepherds this should be ready-to-merge once CI passes and we have LGTMs. |
lizan
approved these changes
Jan 5, 2020
mattklein123
approved these changes
Jan 6, 2020
Member
|
(I didn't review this line by line but generally looks sane. Amazing work!. Let's merge and see what happens.) |
sthagen
added a commit
to sthagen/envoyproxy-envoy
that referenced
this pull request
Jan 6, 2020
all: upgrade Envoy source to v3alpha API. (envoyproxy#9546)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the mega-upgrade patch taking Envoy from v2 to v3alpha internally. It consists of a mechanically generated upgrade patch ("Mechanical upgrade via api_boost.py.") and some post-upgrade manual fixups.
Risk level: Very high. It's possible that internal changes might manifest on the wire in unanticipated ways, e.g. via type URLs or config rejection.
Testing: All tests pass.
Fixes #8082