api: rename ConnectionSourceType::LOCAL to SAME_IP_OR_LOOPBACK.#9518
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Dec 30, 2019
Merged
api: rename ConnectionSourceType::LOCAL to SAME_IP_OR_LOOPBACK.#9518htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Also Utility::isLocalConnection() to Utility::isSameIpOrLoopback(). The idea is to improve descriptive accuracy, see envoyproxy#7840 (comment). Risk level: Low Testing: additional protoxform golden test added for enum value renames. Fixes envoyproxy#8081 Signed-off-by: Harvey Tuch <htuch@google.com>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
…yproxy#9518) Also Utility::isLocalConnection() to Utility::isSameIpOrLoopback(). The idea is to improve descriptive accuracy, see envoyproxy#7840 (comment). Risk level: Low Testing: additional protoxform golden test added for enum value renames. Fixes envoyproxy#8081 Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also Utility::isLocalConnection() to Utility::isSameIpOrLoopback(). The
idea is to improve descriptive accuracy, see
#7840 (comment).
Risk level: Low
Testing: additional protoxform golden test added for enum value renames.
Fixes #8081
Signed-off-by: Harvey Tuch htuch@google.com