test: deflake integration tests with TSAN.#945
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom May 11, 2017
Merged
test: deflake integration tests with TSAN.#945mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
See envoyproxy#944. I don't think we properly understand the root cause yet, but this at least unblocks CI.
mattklein123
approved these changes
May 11, 2017
tschroed
pushed a commit
to tschroed/envoy
that referenced
this pull request
May 11, 2017
See envoyproxy#944. I don't think we properly understand the root cause yet, but this at least unblocks CI.
tschroed
pushed a commit
to tschroed/envoy
that referenced
this pull request
May 16, 2017
See envoyproxy#944. I don't think we properly understand the root cause yet, but this at least unblocks CI.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Pass stats update interval **What this PR does / why we need it**:Pass stats update interval from config to proxy, so that we can control the frequency to update Envoy stats. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#132 istio/old_mixerclient_repo#132 **Special notes for your reviewer**: **Release note**: ```release-note ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, there was a flake in the use of bytes.Buffer passed to EG command as well as on our aigw run side, we are reading it concurrently. This fixes it temporarily by passing os.Stdout or io.Discard. The race was occasionally happening on CI which was causing the flake, so this fixes it. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #944. I don't think we properly understand the root cause
yet, but this at least unblocks CI.