Skip to content

server: fix bogus startup log message#9404

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
jpeach:fix-startup-message
Dec 19, 2019
Merged

server: fix bogus startup log message#9404
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
jpeach:fix-startup-message

Conversation

@jpeach
Copy link
Copy Markdown
Contributor

@jpeach jpeach commented Dec 19, 2019

When Envoy splits the empty --disable-extensions flag at startup,
it ends up with a vector containing a single empty string. Since
the vector isn't empty, it tries to disable the extension with an
empty name. The fix is to not try to split the option string if it
is empty.

Risk Level: Low
Testing: Manually observed startup log
Docs Changes: N/A
Release Notes: N/A
Fixes: #9377

When Envoy splits the empty `--disable-extensions` flag at startup,
it ends up with a vector containing a single empty string. Since
the vector isn't empty, it tries to disable the extension with an
empty name. The fix is to not try to split the option string if it
is empty.

This fixes envoyproxy#9377.

Signed-off-by: James Peach <jpeach@apache.org>
@mattklein123 mattklein123 merged commit c468aa8 into envoyproxy:master Dec 19, 2019
spenceral added a commit to spenceral/envoy that referenced this pull request Dec 20, 2019
* master: (167 commits)
  stats: Avoid asserts in fuzz-tests by eliminating arbitrary length limits, using the new MemBlock wrapper for memcpy (envoyproxy#8779)
  Make %UPSTREAM_LOCAL_ADDRESS% access-log format work for HTTP requests. (envoyproxy#9362)
  tools: API boosting support for using decls and enum constants. (envoyproxy#9418)
  Fix incorrect cluster InitializePhase type (envoyproxy#9379)
  build: fix merge race between envoyproxy#9241 and envoyproxy#9413. (envoyproxy#9427)
  fuzz: fix incorrect evaluator test (envoyproxy#9402)
  server: fix bogus startup log message (envoyproxy#9404)
  tools: Add protoxform tests (envoyproxy#9241)
  api: options after import (envoyproxy#9413)
  misc: use std::move instead of constructing a copy (envoyproxy#9415)
  tools: API boosting support for rewriting elaborated types. (envoyproxy#9375)
  docs: fix invalid transport_socket value (envoyproxy#9403)
  fix typo in docs (envoyproxy#9394)
  srds: remove to-de-removed scopes first and then apply additions to avoid scope key conflict. (envoyproxy#9366)
  api: generate whole directory and sync (envoyproxy#9382)
  bazel: Add load statements for proto_library (envoyproxy#9367)
  Fix typo (envoyproxy#9388)
  Correct test of OptionsImpl argc type (Was: Correct type for std::array size() result) (envoyproxy#9290)
  http1 encode trailers in chunk encoding (envoyproxy#8667)
  Add mode to PipeInstance (envoyproxy#8423)
  ...
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
When Envoy splits the empty `--disable-extensions` flag at startup,
it ends up with a vector containing a single empty string. Since
the vector isn't empty, it tries to disable the extension with an
empty name. The fix is to not try to split the option string if it
is empty.

This fixes envoyproxy#9377.

Signed-off-by: James Peach <jpeach@apache.org>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Envoy emits a bogus "failed to disable extension" message at startup

3 participants