Merged
Conversation
Member
Author
|
@lyft/network-team |
wgallagher
reviewed
Sep 22, 2016
| @@ -124,9 +124,6 @@ void RpcChannelImpl::onFailure(Http::AsyncClient::FailureReason reason) { | |||
| case Http::AsyncClient::FailureReason::Reset: | |||
There was a problem hiding this comment.
given that this is the only possibility, maybe the parameter can be removed completely? Does FailureReason even need to exist now?
Member
Author
There was a problem hiding this comment.
I went back and forth on this. Since the enum is already there and plumbed everywhere, it would be a lot of work to change it to no parameters, then we might need a parameter again. I'm inclined to leave it for now?
| void healthCheck(bool is_hc) override { hc_request_ = is_hc; } | ||
|
|
||
| const std::string& protocol_; | ||
| SystemTime start_time_; |
RomanDzhabarov
approved these changes
Sep 22, 2016
| : protocol_(protocol), start_time_(std::chrono::system_clock::now()) {} | ||
|
|
||
| // Http::AccessLog::RequestInfo | ||
| SystemTime startTime() const override { return start_time_; } |
Member
Author
There was a problem hiding this comment.
it's an integer, no point in returning a reference
| void LightStepSink::onSuccess(Http::MessagePtr&&) { stats_.collector_success_.inc(); } | ||
| void LightStepSink::onSuccess(Http::MessagePtr&& response) { | ||
| uint64_t response_code = Http::Utility::getResponseStatus(response->headers()); | ||
| if (response_code == enumToInt(Http::Code::OK)) { |
Member
There was a problem hiding this comment.
minor, might be better to CodeUtility::is2xx(response_code)
|
👍 |
lspas-volvo
pushed a commit
to sel-vcc/envoy
that referenced
this pull request
Sep 18, 2019
network: fix misaligned memory access in setsockopt().
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
Per #90, we will migrate to dynamic modules in the second or third version of AI Gateway, the public configuration package must not be coupled with extproc (see the description in the issue). This renames `extprocconfig` to more generic (and accurate) name as `filterconfig`. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have increasing use cases where we want Envoy filters to be able to make
direct HTTP calls but use the full router feature set (retries, etc.). We also want
all of the same stats. Previously, the HTTP async client didn't support most of
the router features and also had some code duplication. This change makes the
HTTP async client use the router directly so that all standard features are
available via request headers directly.
In follow ups we will add the ability for the async client to write to an access log,
as well as for a constant route to be passed in, which will be higher
performance than having to use request headers that need to be parsed.