udp_proxy: implement idle timeout and some stats#8999
Merged
mattklein123 merged 12 commits intomasterfrom Nov 25, 2019
Merged
Conversation
Another bunch of work towards #492. The remaining work is proper wiring up of upstream cluster management, host health, etc. and documentation. This will be done in the next PR. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@danzh2010 @goaway PTAL |
Signed-off-by: Matt Klein <mklein@lyft.com>
htuch
reviewed
Nov 13, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
@envoyproxy/api-shepherds API LGTM modulo nits. There are breaking changes, but this is a v2alpha API.
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
danzh2010
reviewed
Nov 15, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
danzh2010
reviewed
Nov 21, 2019
Contributor
danzh2010
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good over all with a few nits.
danzh2010
reviewed
Nov 22, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@danzh2010 updated PTAL |
danzh2010
reviewed
Nov 25, 2019
| const Network::UdpRecvData::LocalPeerAddresses addresses_; | ||
| const Upstream::HostConstSharedPtr host_; | ||
| // TODO(mattklein123): Consider replacing an idle timer for each session with a last used | ||
| // time stamp and a periodic scan of all sessions to look for timeouts. This solution is simple, |
Contributor
There was a problem hiding this comment.
Might consider to use linked hash map to hold all the sessions in that case.
It can also be one alarm per session, but scheduled once per loop instead of once per packet. Not necessarily to be a common idle timer cross all sessions.
Member
Author
There was a problem hiding this comment.
Agreed there is a bunch we can do. Let's tackle this in a follow up. Thanks for the good discussion. :)
Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another bunch of work towards
#492.
The remaining work is proper wiring up of upstream cluster
management, host health, etc. and documentation. This will
be done in the next PR.
Risk Level: Low
Testing: New integration/unit tests
Docs Changes: N/A
Release Notes: N/A