thrift-proxy: add support for cluster header based routing#8994
Merged
htuch merged 6 commits intoenvoyproxy:masterfrom Nov 15, 2019
Merged
thrift-proxy: add support for cluster header based routing#8994htuch merged 6 commits intoenvoyproxy:masterfrom
htuch merged 6 commits intoenvoyproxy:masterfrom
Conversation
Fixes: envoyproxy#8991 Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
zuercher
requested changes
Nov 12, 2019
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks! I think this needs to be factored a bit differently, as explained below.
source/extensions/filters/network/thrift_proxy/router/router_impl.cc
Outdated
Show resolved
Hide resolved
added 2 commits
November 12, 2019 18:32
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
cc: @htuch for API. |
htuch
reviewed
Nov 13, 2019
api/envoy/config/filter/network/thrift_proxy/v2alpha1/route.proto
Outdated
Show resolved
Hide resolved
added 2 commits
November 14, 2019 10:34
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
zuercher
approved these changes
Nov 14, 2019
htuch
approved these changes
Nov 15, 2019
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Jan 31, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate this filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
pushed a commit
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (#9089 and #6549) and some necessary stats/features have been added (#9203 and #8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8991
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com