ext_authz: Fix missing body in CheckRequest for HTTP/2#8877
Merged
dio merged 12 commits intoenvoyproxy:masterfrom Nov 14, 2019
dio:fix-8666
Merged
ext_authz: Fix missing body in CheckRequest for HTTP/2#8877dio merged 12 commits intoenvoyproxy:masterfrom dio:fix-8666
dio merged 12 commits intoenvoyproxy:masterfrom
dio:fix-8666
Conversation
This patch fixes missing body in CheckRequest when the with_request_body is enabled and the downstream protocol is HTTP/2. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Member
Author
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
gsagula
previously approved these changes
Nov 8, 2019
Member
gsagula
left a comment
There was a problem hiding this comment.
It looks good to me. Thanks for adding the integration test!
| uint64_t request_size) { | ||
| initializeWithDownstreamProtocol(downstream_protocol); | ||
| initiateClientConnection(request_size); | ||
| waitForExtAuthzRequest(fmt::format(R"EOF( |
Member
There was a problem hiding this comment.
@dio The integration tests are great but is there a way that we can make this part a bit more readable?
Member
Author
|
@zuercher could you help to review this? Thank you! |
zuercher
reviewed
Nov 11, 2019
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks for working out the integration tests. I have one question about how this works in cases where there are multiple decodeData calls.
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Member
Author
|
@zuercher do we need more changes? |
mayflower-markus
pushed a commit
to mayflower-markus/envoy
that referenced
this pull request
Dec 2, 2019
This patch fixes the missing body in `CheckRequest` when the `with_request_body` is enabled and the downstream protocol is HTTP/2. Fixes envoyproxy#8666 Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This patch fixes the missing body in
CheckRequestwhen thewith_request_bodyis enabled and the downstream protocol is HTTP/2.Risk Level: Low
Testing: integration-test
Docs Changes: N/A
Release Notes: N/A
Fixes #8666
Signed-off-by: Dhi Aurrahman dio@tetrate.io