access log: support filter state objects#8803
Merged
lizan merged 15 commits intoenvoyproxy:masterfrom Nov 5, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
kyessenov
reviewed
Oct 30, 2019
kyessenov
reviewed
Oct 30, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
@envoyproxy/api-shepherds ping |
htuch
suggested changes
Oct 31, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Generally approve of this approach, just some clarification request..
/wait
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
@htuch gentle ping, I'm blocked on this one to make WasmState serializable. |
htuch
reviewed
Nov 4, 2019
htuch
reviewed
Nov 4, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
htuch
previously approved these changes
Nov 5, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
@htuch can you approve again? resolved conflicts on version_history.rst because we're in new version. |
Member
Author
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run envoy-macos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
htuch
approved these changes
Nov 5, 2019
lizan
added a commit
to envoyproxy/envoy-wasm
that referenced
this pull request
Nov 11, 2019
Cherry-pick envoyproxy/envoy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
added a commit
to lizan/envoy
that referenced
this pull request
Nov 11, 2019
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
howardjohn
pushed a commit
to istio/envoy
that referenced
this pull request
Nov 12, 2019
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds serialization method to filter state and use from logger if specified.
Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Will add
Fixes #8790
Signed-off-by: Lizan Zhou lizan@tetrate.io