build: ignore go-control-plane mirror git commit error code#8703
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 22, 2019
Merged
build: ignore go-control-plane mirror git commit error code#8703mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
mattklein123
requested changes
Oct 21, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for the fix. One small comment.
/wait
tools/api/generate_go_protobuf.py
Outdated
| git(repo, 'commit', '-s', '-m', MIRROR_MSG + sha) | ||
| git(repo, 'push', 'origin', BRANCH) | ||
| except: | ||
| print('Failed to commit changes, skipping push') |
Member
There was a problem hiding this comment.
The push itself can fail, correct? Shouldn't we not swallow that?
Contributor
Author
There was a problem hiding this comment.
We still get the text output in the CI logs to diagnose the error. I just don't want to break post-submit due to some issues that requires human involvement.
Member
There was a problem hiding this comment.
How are we going to know it failed if we don't see it failed? Can you just handle the empty commit case directly?
Contributor
Author
There was a problem hiding this comment.
Ok, let's just allow empty commits with the synced SHA from envoy. It doesn't cost much and makes it easier to cross-reference.
Contributor
Author
There was a problem hiding this comment.
Keep in mind, we already filter for SHAs that affect api/. Not all api/ changes affect generated go code, which caused the problem.
Signed-off-by: Kuat Yessenov <kuat@google.com>
spenceral
added a commit
to spenceral/envoy
that referenced
this pull request
Oct 23, 2019
* master: (54 commits) Update dependencies - Go, Bazel toos, xxHash, nanopb, rules_go, curl, protobuf, Jinja, yaml-cpp, re2 (envoyproxy#8728) test: increase coverage of listener_manager_impl.cc (envoyproxy#8737) test: modify some macros to reduce number of uncovered lines reported (envoyproxy#8725) build: add a script to setup clang (envoyproxy#8682) http: fix ssl_redirect on external (envoyproxy#8664) docs: update fedora build requirements (envoyproxy#8641) fix draining listener removal logs (envoyproxy#8733) dubbo: fix router doc (envoyproxy#8734) server: provide server health status when stats disabled (envoyproxy#8482) router: adding a knob to configure a cap on buffering for shadowing/retries (envoyproxy#8574) tcp proxy: add default 1 hour idle timeout (envoyproxy#8705) thrift: fix filter names in docs (envoyproxy#8726) Quiche changes to avoid gcc flags on Windows (envoyproxy#8514) test: increase test coverage in Router::HeaderParser (envoyproxy#8721) admin: add drain listeners endpoint (envoyproxy#8415) buffer filter: add content-length when ending stream with trailers (envoyproxy#8609) clarify draining option docs (envoyproxy#8712) build: ignore go-control-plane mirror git commit error code (envoyproxy#8703) api: remove API type database from checked in artifacts. (envoyproxy#8716) admin: correct help strings (envoyproxy#8710) ... Signed-off-by: Spencer Lewis <slewis@squareup.com>
derekargueta
pushed a commit
to derekargueta/envoy
that referenced
this pull request
Oct 24, 2019
…xy#8703) Signed-off-by: Kuat Yessenov <kuat@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
This fixes post-submit when there are no changes to the API.
cc @zuercher
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]