Skip to content

ci: mirror .pb.go to envoyproxy/go-control-plane.#8573

Merged
lizan merged 2 commits intoenvoyproxy:masterfrom
htuch:go-mirror-fix
Oct 17, 2019
Merged

ci: mirror .pb.go to envoyproxy/go-control-plane.#8573
lizan merged 2 commits intoenvoyproxy:masterfrom
htuch:go-mirror-fix

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Oct 10, 2019

This reverts "ci: temporarily disable go_mirror while figuring out SSH keys (#8311)",
commit 98c35ef. I've added a new key pair and set this up in both
Circle and GitHub, so pushes should now work.

Signed-off-by: Harvey Tuch htuch@google.com

This reverts "ci: temporarily disable go_mirror while figuring out SSH keys (envoyproxy#8311)",
commit 98c35ef. I've added a new key pair and set this up in both
Circle and GitHub, so pushes should now work.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested review from kyessenov and lizan October 10, 2019 20:36
kyessenov
kyessenov previously approved these changes Oct 10, 2019
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 14, 2019

@lizan can we merge?

@kyessenov
Copy link
Copy Markdown
Contributor

Friendly ping @lizan

@lizan lizan merged commit d230e5b into envoyproxy:master Oct 17, 2019
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
* ci: mirror .pb.go to envoyproxy/go-control-plane.

This reverts "ci: temporarily disable go_mirror while figuring out SSH keys (envoyproxy#8311)",
commit 98c35ef. I've added a new key pair and set this up in both
Circle and GitHub, so pushes should now work.

Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants