ci: improve developer-local docs and make fastbuild envoy binary acce…#852
ci: improve developer-local docs and make fastbuild envoy binary acce…#852mattklein123 merged 7 commits intoenvoyproxy:masterfrom
Conversation
|
Can you hold off on merge, I have a small change suggested by @PiotrSikora |
|
LGTM will wait for @PiotrSikora +1 |
ci/README.md
Outdated
| ENVOY_DOCKER_BUILD_DIR=~/build ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev.server_only' | ||
| ``` | ||
|
|
||
| For a release Envoy binary you can run: |
There was a problem hiding this comment.
s/release Envoy binary/release version of Envoy binary/?
| * `bazel.dev.server_only` — build Envoy static binary under `-c fastbuild`. | ||
| * `bazel.dev.test` — build and run tests under `-c fastbuild`. | ||
| * `bazel.release` — build Envoy static binary and run tests under `-c opt`. | ||
| * `bazel.release.server_only` — build Envoy static binary under `-c opt`. |
There was a problem hiding this comment.
Why do we have bazel.dev.test, but bazel.release (without .test)?
There was a problem hiding this comment.
Because the bazel.release target is used for the CI and combines the static binary build and tests (for performance reasons). For developers, you want a target that just builds/runs the tests (not as useful in CI). I can add a bazel.release.tests that only does the tests if you think it would be useful to developers.
I feel that so far, I'm hearing from folks like @moderation that they'd like the ability to build using the Docker image, but not for development work per se.
There was a problem hiding this comment.
Let me rephrase, we have:
bazel.release.server_onlyandbazel.dev.server_only, both building only static binary with different-coptions,baze.releaseandbazel.dev.test, both building and running test with different-coptions.
My question is why one has .test suffix, but not ther other.
I'm just nitpicking, it's not that important.
There was a problem hiding this comment.
(discussed this offline, @htuch is going to add binary build to bazel.dev.test and rename it to bazel.dev)
| The artifacts can be found in `/tmp/envoy-docker-build/envoy/source/exe/envoy` (or wherever | ||
| `$ENVOY_DOCKER_BUILD_DIR` points). | ||
|
|
||
| The `./ci/run_envoy_docker.sh './ci/do_ci.sh <TARGET>'` targets are: |
There was a problem hiding this comment.
Was this accidentally removed or on purpose?
Did a quick experiment to see how Envoy Mobile performs now as a library Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: update docs with cpu/battery analysis Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
Did a quick experiment to see how Envoy Mobile performs now as a library Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: update docs with cpu/battery analysis Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
**Description** Replacing `latest` suffix for helm charts and docker image. Replacing suffix with commit message. **Related Issues/PRs (if applicable)** #851 --------- Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
**Description** Follow up on #852 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…ssible.