api/build: automatically generate BUILD files.#8506
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Oct 7, 2019
Merged
Conversation
This provides canonical BUILD formatting and puts protoxform in charge of being able to determine import paths, without having to worry about Bazel implications. Part of envoyproxy#8082. Risk level: Low Testing: tools/proto_sync.py, visual inspection of diffs. Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
reviewed
Oct 7, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
kyessenov
reviewed
Oct 7, 2019
kyessenov
previously approved these changes
Oct 7, 2019
lizan
reviewed
Oct 7, 2019
Member
lizan
left a comment
There was a problem hiding this comment.
thanks, looks great other than a nit.
lizan
approved these changes
Oct 7, 2019
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
This provides canonical BUILD formatting and puts protoxform in charge of being able to determine import paths, without having to worry about Bazel implications. Part of envoyproxy#8082. Risk level: Low Testing: tools/proto_sync.py, visual inspection of diffs. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides canonical BUILD formatting and puts protoxform in charge
of being able to determine import paths, without having to worry about
Bazel implications.
Part of #8082.
Risk level: Low
Testing: tools/proto_sync.py, visual inspection of diffs.
Signed-off-by: Harvey Tuch htuch@google.com