test: use @bazel_tools//tools/cpp/runfiles to find runfiles#8488
Merged
lizan merged 12 commits intoenvoyproxy:masterfrom Oct 7, 2019
Merged
test: use @bazel_tools//tools/cpp/runfiles to find runfiles#8488lizan merged 12 commits intoenvoyproxy:masterfrom
lizan merged 12 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
reviewed
Oct 4, 2019
htuch
reviewed
Oct 4, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
This is overall a really great cleanup and simplification. Nice! Tagging @yanavlasov who is on Google import duty next week, this is likely to require some mangling to make work seamlessly with our internal tree and build system.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
@htuch now the tests are all passed except those requiring envoyproxy/envoy-filter-example#101. |
Member
|
@lizan merge the envoy-filter-example PR. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
approved these changes
Oct 7, 2019
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
…xy#8488) Description: Proper fix for bazelbuild/bazel#7399 from Envoy side, tests should be aware which workspace its testdata is from. Added parameter to TestEnvironment::runfiles{Path,Directory} to specify `workspace`. Using this ability in compile_time_options CI. By using `@bazel_tools//tools/cpp/runfiles`, it also allows test binaries to be invoked outside bazel directly, e.g. `bazel-bin/test/exe/main_common_test`, so the GDB wrapper is no longer needed. Risk Level: Low (test only) Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Proper fix for bazelbuild/bazel#7399 from Envoy side, tests should be aware which workspace its testdata is from. Added parameter to TestEnvironment::runfiles{Path,Directory} to specify
workspace. Using this ability in compile_time_options CI.By using
@bazel_tools//tools/cpp/runfiles, it also allows test binaries to be invoked outside bazel directly, e.g.bazel-bin/test/exe/main_common_test, so the GDB wrapper is no longer needed.Risk Level: Low (test only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Lizan Zhou lizan@tetrate.io