hcm: refactor idle_timeout arming#8475
Merged
snowp merged 1 commit intoenvoyproxy:masterfrom Oct 3, 2019
Merged
Conversation
Moves the check to re-arm closer to where active streams are removed from streams_, making it easier to reason about correctness. Also adds integration test coverage around HCM idle timeout handling. Signed-off-by: Snow Pettersen <snowp@squareup.com>
alyssawilk
approved these changes
Oct 3, 2019
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Looks great, thanks very much for the cleanup.
One request - can you run 1k runs with the deflake instructions (test/integration/READ.md) just to make sure the timeout isn't too aggressive? I doubt it'd disconnect between connection and stream but better to find out before we merge :-)
Contributor
Author
|
No failures after running it a bunch of times. I started off with 1ms timeout which was definitely flaky, 100ms seems ok. |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Moves the check to re-arm closer to where active streams are removed from streams_, making it easier to reason about correctness. Also adds integration test coverage around HCM idle timeout handling. Signed-off-by: Snow Pettersen <snowp@squareup.com>
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
Moves the check to re-arm closer to where active streams are removed from streams_, making it easier to reason about correctness. Also adds integration test coverage around HCM idle timeout handling. Signed-off-by: Snow Pettersen <snowp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the check to re-arm closer to where active streams are removed
from streams_, making it easier to reason about correctness. Also
adds integration test coverage around HCM idle timeout handling.
Signed-off-by: Snow Pettersen snowp@squareup.com
Risk Level: Low
Testing: Existing tests, new IT
Docs Changes: n/a
Release Notes: n/a