Skip to content

initialize dispatch_buffered_data_ to fix msan error#8474

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
ahedberg:connection_impl_msan_fix
Oct 3, 2019
Merged

initialize dispatch_buffered_data_ to fix msan error#8474
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
ahedberg:connection_impl_msan_fix

Conversation

@ahedberg
Copy link
Copy Markdown
Contributor

@ahedberg ahedberg commented Oct 3, 2019

Signed-off-by: Ashley Hedberg ahedberg@google.com

Description: Explicitly initialize dispatch_buffered_data_ to fix an msan error uncovered while importing Envoy at Google.
Risk Level: low
Testing: src/test/integration/... tests failed under msan before this change, and now pass
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Ashley Hedberg <ahedberg@google.com>
@ahedberg
Copy link
Copy Markdown
Contributor Author

ahedberg commented Oct 3, 2019

/assign @alyssawilk

@mattklein123 mattklein123 merged commit 34d49ff into envoyproxy:master Oct 3, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Signed-off-by: Ashley Hedberg <ahedberg@google.com>
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
Signed-off-by: Ashley Hedberg <ahedberg@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants