Skip to content

tls: override ALPN in transport socket options#8470

Merged
lizan merged 3 commits intoenvoyproxy:masterfrom
yxue:transportsocket
Oct 4, 2019
Merged

tls: override ALPN in transport socket options#8470
lizan merged 3 commits intoenvoyproxy:masterfrom
yxue:transportsocket

Conversation

@yxue
Copy link
Copy Markdown
Member

@yxue yxue commented Oct 3, 2019

Signed-off-by: crazyxy yxyan@google.com

Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of #8197

Signed-off-by: crazyxy <yxyan@google.com>
@yxue yxue requested a review from lizan as a code owner October 3, 2019 00:28
@lizan lizan self-assigned this Oct 3, 2019
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was doing similar thing for upstream SNI override with HTTP so this helps on that too.

Signed-off-by: crazyxy <yxyan@google.com>
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo last one comment.

Signed-off-by: crazyxy <yxyan@google.com>
@lizan lizan merged commit f112818 into envoyproxy:master Oct 4, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of envoyproxy#8197

Signed-off-by: crazyxy <yxyan@google.com>
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of envoyproxy#8197

Signed-off-by: crazyxy <yxyan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants