Skip to content

build: not refer @envoy//api at all#8469

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
lizan:bazelignore_fix
Oct 3, 2019
Merged

build: not refer @envoy//api at all#8469
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
lizan:bazelignore_fix

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Oct 2, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Fixes #8455

Risk Level: Low
Testing: Tested last_green bazel build at 886c0a4d5b69022b0329e30d07bbe7a274e31aa0.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from htuch October 2, 2019 22:12
@lizan
Copy link
Copy Markdown
Member Author

lizan commented Oct 2, 2019

cc @aehlig

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@mattklein123 mattklein123 merged commit 08a71f3 into envoyproxy:master Oct 3, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Envoy uses label @envoy//api:BUILD despite ignoring api

2 participants