Skip to content

api: remove stale annotations.#8468

Merged
htuch merged 4 commits intoenvoyproxy:masterfrom
htuch:annotations-cleanup
Oct 3, 2019
Merged

api: remove stale annotations.#8468
htuch merged 4 commits intoenvoyproxy:masterfrom
htuch:annotations-cleanup

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Oct 2, 2019

  • [#not-implemented-warn:] was barely used and its purposes are better
    served by [#not-implemented-hide:].

  • [#proto-status:] was there for an earlier style of versioning, where
    APIs were "frozen" or "draft", etc. Now we have semantic versioning
    and a regular API clock as per Stable Envoy API versions #6271.

Part of #8371.

Risk level: Low (docs only).
Testing: Docs rebuild.

Signed-off-by: Harvey Tuch htuch@google.com

* [#not-implemented-warn:] was barely used and its purposes are better
  served by [#not-implemented-hide:].

* [#proto-status:] was there for an earlier style of versioning, where
  APIs were "frozen" or "draft", etc. Now we have semantic versioning
  and a regular API clock as per envoyproxy#6271.

Part of envoyproxy#8371.

Risk level: Low (docs only).
Testing: Docs rebuild.

Signed-off-by: Harvey Tuch <htuch@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8468 was opened by htuch.

see: more, trace.

@htuch htuch requested a review from mattklein123 October 2, 2019 21:25
@htuch htuch changed the title api: remove stale deprecations. api: remove stale annotations. Oct 3, 2019
@mattklein123
Copy link
Copy Markdown
Member

Awesome but needs master merge.

/wait

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@htuch htuch merged commit 2c4b6f2 into envoyproxy:master Oct 3, 2019
@htuch htuch deleted the annotations-cleanup branch October 3, 2019 18:47
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
* [#not-implemented-warn:] was barely used and its purposes are better
  served by [#not-implemented-hide:].

* [#proto-status:] was there for an earlier style of versioning, where
  APIs were "frozen" or "draft", etc. Now we have semantic versioning
  and a regular API clock as per envoyproxy#6271.

Part of envoyproxy#8371.

Risk level: Low (docs only).
Testing: Docs rebuild.

Signed-off-by: Harvey Tuch <htuch@google.com>
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
* [#not-implemented-warn:] was barely used and its purposes are better
  served by [#not-implemented-hide:].

* [#proto-status:] was there for an earlier style of versioning, where
  APIs were "frozen" or "draft", etc. Now we have semantic versioning
  and a regular API clock as per envoyproxy#6271.

Part of envoyproxy#8371.

Risk level: Low (docs only).
Testing: Docs rebuild.

Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants