test: fix and add mock ProtoBufferEq matchers#8459
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 3, 2019
Merged
test: fix and add mock ProtoBufferEq matchers#8459mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Fred Douglas <fredlas@google.com>
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ProtoBufferEqIgnoringField's formatting, add ProtoBufferEqIgnoreRepeatedFieldOrdering.
Both are similar to the test/test_common/utility versions.
Risk Level: none
Testing: only changes format of test failure error messages