grpc: move ifdefs out of headers.#8458
Merged
jmarantz merged 1 commit intoenvoyproxy:masterfrom Oct 2, 2019
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ahedberg
approved these changes
Oct 2, 2019
Contributor
Author
|
@envoyproxy/senior-maintainers |
lizan
approved these changes
Oct 2, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: It is problematic to have ifdefs for fields in class definitions in a header file that's used at the boundary of Envoy as a library, such as main_common.h. This PR moves the ifdef into the .cc file so that the compilation of that module is the only one that needs to see the ifdef
Risk Level: low
Testing: //test/common/grpc/...
Docs Changes: n/a
Release Notes: n/a