Proof of Concept: Introduce ServerFactoryContext#8454
Closed
lambdai wants to merge 11 commits intoenvoyproxy:masterfrom
Closed
Proof of Concept: Introduce ServerFactoryContext#8454lambdai wants to merge 11 commits intoenvoyproxy:masterfrom
lambdai wants to merge 11 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Contributor
Author
htuch
pushed a commit
that referenced
this pull request
Oct 18, 2019
Introduce ServerFactoryContext which is an implementation of CommonFactoryContext. Comparing to ListenerFactoryContext, ServerFactoryContext has a wider lifetime. This is the prerequisite to share rds configuration among listeners. Also experimenting move messageValidateVisitor out of CommonFactoryContext. The benefit is that now Server::Instance perfectly implements CommonFactoryContext. ServerFactoryContext doesn't implement the function. The test shows it is never invoked. Will put messageValidateVisitor into FactoryContext: this piece of work will be done in follow up PR This PR is extracted from #8454 Fixes #8303 Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduce
ServerFactoryContextwhich is an implementation ofCommonFactoryContext. Comparing toListenerFactoryContext,ServerFactoryContexthas a wider lifetime.In this PR I also prove
ServerFactoryContextwould allow multiple listeners share aRdsConfigProviderand save huge of memory and CPU[x] Compile envoy-static with
ServerFactoryContext: RdsConfigProvider, PerFilterConfig, Route, VhdsSubscription should useServerFactoryContext[ ] Safely implement ServerFactoryCxtUtil::generateServerFactoryContext
[ ] Server::Instance should implement
ServerFactoryContext[ ] RdsConfigProvider should own RdsSubscription
[ ] RdsConfigProvider should be able to notify multiple listeners and listeners could wait on RdsProvider in ready state
[ ] tons of broken tests due to signature change
Risk Level:
Testing:
Docs Changes:
Release Notes:
Fixes #8303